refactor(site): improve settings option #11489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Jan 8, 2024
| border: `1px solid ${borderColor}`, | ||
| }} | ||
| /> | ||
| </OptionConfigContext.Provider> |
There was a problem hiding this comment.
Are we missing some children in here? Not sure how what context is wrapping.
There was a problem hiding this comment.
children is a regular prop from any HTML element so we don't need to pass it manually since it is already inside of the props.
Kira-Pilot
reviewed
Jan 8, 2024
| const theme = useTheme(); | ||
| const { isSource } = useContext(OptionConfigContext); |
There was a problem hiding this comment.
Is there a way to target the background-color via CSS nesting in the parent? Introducing a new context for a style ternary in one place seems a little heavy-handed to me.
There was a problem hiding this comment.
I was wondering the same 🤔 going to make that instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
