From ad69c0bd7a85b212bf5a0fc2713dd657ef6f0da1 Mon Sep 17 00:00:00 2001 From: kylecarbs Date: Mon, 25 Apr 2022 18:04:37 +0000 Subject: [PATCH] test: Wait for WorkspaceResources to complete before exiting This caused a flake seen in: https://github.com/coder/coder/runs/6162655678?check_suite_focus=true#step:9:87 --- cli/cliui/resources_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cli/cliui/resources_test.go b/cli/cliui/resources_test.go index 571b49bb67746..3a782321a7a9c 100644 --- a/cli/cliui/resources_test.go +++ b/cli/cliui/resources_test.go @@ -17,6 +17,7 @@ func TestWorkspaceResources(t *testing.T) { t.Run("SingleAgentSSH", func(t *testing.T) { t.Parallel() ptty := ptytest.New(t) + done := make(chan struct{}) go func() { err := cliui.WorkspaceResources(ptty.Output(), []codersdk.WorkspaceResource{{ Type: "google_compute_instance", @@ -32,14 +33,17 @@ func TestWorkspaceResources(t *testing.T) { WorkspaceName: "example", }) require.NoError(t, err) + close(done) }() ptty.ExpectMatch("coder ssh example") + <-done }) t.Run("MultipleStates", func(t *testing.T) { t.Parallel() ptty := ptytest.New(t) disconnected := database.Now().Add(-4 * time.Second) + done := make(chan struct{}) go func() { err := cliui.WorkspaceResources(ptty.Output(), []codersdk.WorkspaceResource{{ Transition: database.WorkspaceTransitionStart, @@ -82,9 +86,11 @@ func TestWorkspaceResources(t *testing.T) { HideAccess: false, }) require.NoError(t, err) + close(done) }() ptty.ExpectMatch("google_compute_disk.root") ptty.ExpectMatch("google_compute_instance.dev") ptty.ExpectMatch("coder ssh dev.postgres") + <-done }) }