Skip to content

fix: return a more sophisticated error for device failure on 429 #11554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: return a more sophisticated error for device failure on 429 #11554

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f579e
fix: return a more sophisticated error for device failure on 429
Emyrk Jan 10, 2024
0ccf9c5
Add unit test
Emyrk Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: return a more sophisticated error for device failure on 429
  • Loading branch information
@Emyrk
Emyrk committed Jan 10, 2024
commit 43f579e48aa527c643f454675c5fc6daca80fb14
9 changes: 8 additions & 1 deletion coderd/externalauth/externalauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,14 @@ func (c *DeviceAuth) AuthorizeDevice(ctx context.Context) (*codersdk.ExternalAut
}
err = json.NewDecoder(resp.Body).Decode(&r)
if err != nil {
return nil, err
// Some status codes do not return json payloads, and we should
// return a better error.
switch resp.StatusCode {
case http.StatusTooManyRequests:
return nil, fmt.Errorf("rate limit hit, unable to authorize device. please try again later")
default:
return nil, err
}
}
if r.ErrorDescription != "" {
return nil, xerrors.New(r.ErrorDescription)
Expand Down