Skip to content

feat: add a character counter for fields with length limits #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 10, 2024

Closes #11012

  • refactorsgetFormHelpers to accept an options object
  • adds a maxLength option which will display a message and character counter for fields with length limits
  • set maxLength option for template description fields

- refactors`getFormHelpers` to accept an options object
- adds a `maxLength` option which will display a message and character counter for fields with length limits
- set `maxLength` option for template description fields
@aslilac aslilac force-pushed the description-length-warning branch from 56172e8 to 01fe466 Compare January 11, 2024 17:04
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good I just missed a screenshot showing the change. I also tried to find something on Chromatic but I didn't find it.

@aslilac
Copy link
Member Author

aslilac commented Jan 11, 2024

oh I meant to add a story for it too, I'll do that before merging

@aslilac aslilac merged commit 05eac64 into main Jan 11, 2024
@aslilac aslilac deleted the description-length-warning branch January 11, 2024 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants