refactor: curry GetFormHelpers #1156
Merged
+72
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
+ Coverage 66.24% 66.43% +0.19%
==========================================
Files 255 263 +8
Lines 16120 16426 +306
Branches 156 156
==========================================
+ Hits 10678 10912 +234
- Misses 4335 4390 +55
- Partials 1107 1124 +17
Continue to review full report at Codecov.
|
greyscaled
approved these changes
Apr 25, 2022
| @@ -49,29 +49,30 @@ export const AccountForm: React.FC<AccountFormProps> = ({ | |||
| validationSchema, | |||
| onSubmit, | |||
| }) | |||
| const getFieldHelpers = getFormHelpers<AccountFormValues>(form, formErrors) | |||
There was a problem hiding this comment.
praise: I love this solution, the curry is very clean and reminds me of an improvement upon the old wrappers!
| // getIn is a util function from Formik that gets at any depth of nesting | ||
| // and is necessary for the types to work | ||
| const touched = getIn(form.touched, name) | ||
| const apiError = getIn(formErrors, name) |
There was a problem hiding this comment.
praise: improve var name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getFormHelpersto take two arguments and return a function that takes one argument, so we don't have to repeat args as much. Also adds test coverage for using API errors in the form. In keeping with the existing code, I show the API error if we have both, but I don't have a strong opinion on it.