Skip to content

feat(site): add docs links on health page #11582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

johnstcn
Copy link
Member

Adds links to the error mesages on the health page.
This is important as we provide specific codes to allow us to send operators to the relevant section of the docs.

image

@johnstcn johnstcn self-assigned this Jan 11, 2024
@johnstcn johnstcn mentioned this pull request Jan 11, 2024
16 tasks
@BrunoQuaresma
Copy link
Collaborator

I think you can make it look better by moving the link into an action like this:

<Alert actions={<Link to="...">See the docs</Link>} />

Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn force-pushed the cj/health-message-code-link branch from 98c3a69 to 298eb12 Compare January 11, 2024 20:23
@johnstcn
Copy link
Member Author

I think you can make it look better by moving the link into an action like this:

<Alert actions={<Link to="...">See the docs</Link>} />

Yep, this looks way better:

image

Thanks Bruno!

@johnstcn johnstcn merged commit 26f5ce6 into main Jan 11, 2024
@johnstcn johnstcn deleted the cj/health-message-code-link branch January 11, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants