Skip to content

feat: add tailnet v2 support to wsproxy coordinate endpoint #11637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: add tailnet v2 support to wsproxy coordinate endpoint #11637

merged 1 commit into from
Jan 18, 2024
+99 −19

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 16, 2024 •
edited
Loading

wsproxy also needs to be updated to use tailnet v2 because the tailnet.Conn stores peers by ID, and the peerID was not being carried by the JSON protocol. This adds a query param to the endpoint to conditionally switch to the new protocol.

This was referenced Jan 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@spikecurtis spikecurtis mentioned this pull request Jan 16, 2024
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Jan 16, 2024
Merged
Merged
@spikecurtis spikecurtis requested a review from coadler January 16, 2024 12:33
@spikecurtis spikecurtis marked this pull request as ready for review January 16, 2024 12:33
@spikecurtis spikecurtis force-pushed the spike/10533-setBlockEndpoints-nodeupdater branch from 3a10b53 to 83ae54d Compare January 17, 2024 04:57
@spikecurtis spikecurtis force-pushed the spike/10533-wsproxy-endpoint branch from 4177202 to 04e3985 Compare January 17, 2024 04:57
@spikecurtis spikecurtis force-pushed the spike/10533-setBlockEndpoints-nodeupdater branch from 83ae54d to 175ebed Compare January 17, 2024 05:41
@spikecurtis spikecurtis force-pushed the spike/10533-wsproxy-endpoint branch from 04e3985 to 64caaac Compare January 17, 2024 05:41
@spikecurtis spikecurtis force-pushed the spike/10533-setBlockEndpoints-nodeupdater branch from 175ebed to 9ee69e8 Compare January 17, 2024 10:03
@spikecurtis spikecurtis force-pushed the spike/10533-wsproxy-endpoint branch from 64caaac to 2bced78 Compare January 17, 2024 10:04
@spikecurtis spikecurtis force-pushed the spike/10533-setBlockEndpoints-nodeupdater branch from 9ee69e8 to 3cb5874 Compare January 17, 2024 11:49
@spikecurtis spikecurtis force-pushed the spike/10533-wsproxy-endpoint branch from 2bced78 to afd20a0 Compare January 17, 2024 11:49
@spikecurtis spikecurtis mentioned this pull request Jan 17, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-setBlockEndpoints-nodeupdater branch from 3cb5874 to 173bcc1 Compare January 18, 2024 05:51
Base automatically changed from spike/10533-setBlockEndpoints-nodeupdater to main January 18, 2024 06:02
@spikecurtis spikecurtis force-pushed the spike/10533-wsproxy-endpoint branch from afd20a0 to 0b9455c Compare January 18, 2024 06:02
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 18, 2024 •
edited
Loading

Merge activity

  • Jan 18, 1:03 AM: Graphite rebased this pull request as part of a merge.
  • Jan 18, 1:10 AM: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit 8910ac7 into main Jan 18, 2024
@spikecurtis spikecurtis deleted the spike/10533-wsproxy-endpoint branch January 18, 2024 06:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @coadler