Skip to content

fix: close pg PubSub listener to avoid race #11640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: close pg PubSub listener to avoid race #11640

merged 1 commit into from
Jan 18, 2024
+26 −10

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 16, 2024 •
edited
Loading

@spikecurtis Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis requested a review from mafredri January 16, 2024 12:50
@spikecurtis spikecurtis marked this pull request as ready for review January 16, 2024 12:50
mafredri
mafredri approved these changes Jan 16, 2024
View reviewed changes
@spikecurtis spikecurtis force-pushed the spike/pg-pubsub-close-race branch from 0db909c to acf2f3f Compare January 17, 2024 04:54
@spikecurtis spikecurtis requested a review from mafredri January 17, 2024 04:55
mafredri
mafredri approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving p.cancel() to closeListener as well so that it's triggered by listen closing, but otherwise looks good. 👍🏻

@spikecurtis spikecurtis merged commit 387723a into main Jan 18, 2024
@spikecurtis spikecurtis deleted the spike/pg-pubsub-close-race branch January 18, 2024 05:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @mafredri