Skip to content

feat: automatically activate dormant workspaces when manually started #11655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jan 16, 2024

If a user is manually starting a workspace then we should automatically activate it if it's dormant.

@sreya sreya requested a review from Emyrk January 16, 2024 22:25
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only solves it from the cli perspective. Should we do this on the server side so the ui has the same behavior?

@sreya
Copy link
Collaborator Author

sreya commented Jan 16, 2024

The UI prompts the user to activate it prior to starting it.

Screenshot 2024-01-16 at 4 34 46 PM

@sreya sreya requested a review from Emyrk January 16, 2024 22:35
@sreya sreya merged commit 1196f83 into main Jan 16, 2024
@sreya sreya deleted the jon/startdormant branch January 16, 2024 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants