Skip to content

feat: set peers lost when disconnected from coordinator #11681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: set peers lost when disconnected from coordinator #11681

merged 1 commit into from
Jan 22, 2024
+226 −28

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 18, 2024 •
edited
Loading

Adds support to Coordination to call SetAllPeersLost() when it is closed. This ensure that when we disconnect from a Coordinator, we set all peers lost.

This covers CoderSDK (CLI client) and Agent. Next PR will cover MultiAgent (notably, wsproxy).

This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis requested a review from coadler January 18, 2024 10:03
@spikecurtis spikecurtis marked this pull request as ready for review January 18, 2024 10:05
@spikecurtis spikecurtis force-pushed the spike/10533-setAllPeersLost branch from 1a2dccd to 48d4734 Compare January 19, 2024 06:59
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from caedbc8 to 951f803 Compare January 19, 2024 06:59
@spikecurtis spikecurtis mentioned this pull request Jan 19, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-setAllPeersLost branch from 48d4734 to 58f3848 Compare January 19, 2024 08:20
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 951f803 to 771cdf1 Compare January 19, 2024 08:20
@spikecurtis spikecurtis mentioned this pull request Jan 19, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-setAllPeersLost branch from 58f3848 to 2daadfc Compare January 19, 2024 12:36
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 771cdf1 to 2d92458 Compare January 19, 2024 12:36
@spikecurtis spikecurtis mentioned this pull request Jan 19, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-setAllPeersLost branch from 2daadfc to 277215a Compare January 22, 2024 06:58
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 2d92458 to 9c1f310 Compare January 22, 2024 06:58
@spikecurtis spikecurtis force-pushed the spike/10533-setAllPeersLost branch from 277215a to d476a87 Compare January 22, 2024 08:05
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 9c1f310 to 53b97df Compare January 22, 2024 08:05
Base automatically changed from spike/10533-setAllPeersLost to main January 22, 2024 08:12
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 53b97df to 9cf8f03 Compare January 22, 2024 11:18
@spikecurtis spikecurtis mentioned this pull request Jan 22, 2024
Merged
@spikecurtis spikecurtis merged commit 3d85cdf into main Jan 22, 2024
@spikecurtis spikecurtis deleted the spike/10533-set-lost-disconnect branch January 22, 2024 11:26
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @coadler