Skip to content

fix: always attempt external auth refresh when fetching #11762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 25, 2024
Merged

fix: always attempt external auth refresh when fetching #11762

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3b6a39f
fix: always attempt external auth refresh when fetching
Emyrk Jan 22, 2024
5d0489b
refactor validate to check expiary
Emyrk Jan 22, 2024
778184d
linting
Emyrk Jan 23, 2024
2281db2
compile fix
Emyrk Jan 23, 2024
189c8ae
fix return
Emyrk Jan 23, 2024
531f45e
fix extra re-validate call
Emyrk Jan 24, 2024
68b8792
handle no expiry
Emyrk Jan 24, 2024
0879fd6
Fix comment
Emyrk Jan 25, 2024
3d28fe7
fix typo
Emyrk Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting
  • Loading branch information
@Emyrk
Emyrk committed Jan 24, 2024
commit 778184db53fa86ad0d58a7383a3c209bac815fda
2 changes: 1 addition & 1 deletion coderd/workspaceagents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,7 +2100,7 @@ func (api *API) workspaceAgentsExternalAuth(rw http.ResponseWriter, r *http.Requ
httpapi.Write(ctx, rw, http.StatusOK, resp)
}

func (api *API) workspaceAgentsExternalAuthListen(rw http.ResponseWriter, ctx context.Context, externalAuthConfig *externalauth.Config, workspace database.Workspace) {
func (api *API) workspaceAgentsExternalAuthListen(ctx context.Context, rw http.ResponseWriter, externalAuthConfig *externalauth.Config, workspace database.Workspace) {
// Since we're ticking frequently and this sign-in operation is rare,
// we are OK with polling to avoid the complexity of pubsub.
ticker, done := api.NewTicker(time.Second)
Expand Down