Skip to content

feat: use appearance.Fetcher in agentapi #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 23, 2024

This PR updates the Agent API to use the appearance.Fetcher, which is set by entitlement code in Enterprise coderd.

This brings the agentapi into compliance with the Enterprise feature.

@Emyrk
Copy link
Member

Emyrk commented Jan 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This is an epic stack

@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from d63b387 to 5ad6f3f Compare January 23, 2024 18:25
@spikecurtis
Copy link
Contributor Author

This is an epic stack

Imagine if it were one PR!

It's somewhat inflated tho, since it includes all kinds of stuff that was already merged as long as there is anything unmerged in the stack.

@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from 4fc8623 to cdec5e1 Compare January 24, 2024 12:56
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from ae35953 to cfe6dcc Compare January 24, 2024 12:56
@spikecurtis spikecurtis changed the title feat: agentapi uses appearance.Fetcher feat: use appearance.Fetcher in agentapi Jan 24, 2024
@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from cdec5e1 to 79bee1c Compare January 25, 2024 11:24
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from cfe6dcc to 6f243f6 Compare January 25, 2024 11:24
@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from 79bee1c to 529250f Compare January 26, 2024 06:47
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 6f243f6 to a85394d Compare January 26, 2024 06:47
@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from 529250f to 25063cb Compare January 26, 2024 09:24
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from a85394d to 1c21905 Compare January 26, 2024 09:24
@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from 25063cb to 06d2b3d Compare January 26, 2024 15:27
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 1c21905 to 98ab55e Compare January 26, 2024 15:27
@spikecurtis spikecurtis force-pushed the spike/10534-appearance-refactor branch from 06d2b3d to 810bb6e Compare January 29, 2024 07:57
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 98ab55e to 174664c Compare January 29, 2024 07:57
Base automatically changed from spike/10534-appearance-refactor to main January 29, 2024 08:17
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 174664c to 385e74a Compare January 29, 2024 10:44
@spikecurtis spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 385e74a to 43a1c9e Compare January 29, 2024 12:31
@spikecurtis spikecurtis merged commit 207328c into main Jan 29, 2024
@spikecurtis spikecurtis deleted the spike/10534-agentapi-appearance-fetcher branch January 29, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants