Skip to content

feat(site): generates unique workspace names by default #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

feat(site): generates unique workspace names by default #11772

merged 2 commits into from
Jan 23, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 23, 2024
matifali
matifali approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a good addition

matifali
matifali approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matifali approved this PR from Slack with Graphite

@mtojek mtojek self-requested a review January 23, 2024 15:35
mtojek
mtojek previously requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like E2E and regular TS tests are failing.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) January 23, 2024 15:55
@BrunoQuaresma BrunoQuaresma merged commit 369821e into main Jan 23, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/auto-generate-workspace-name branch January 23, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@BrunoQuaresma
Copy link
Collaborator Author

Related to #11742

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@mtojek mtojek mtojek left review comments

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @matifali @mtojek