Skip to content

chore: move FakeCoordinator to tailnettest #11992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

chore: move FakeCoordinator to tailnettest #11992

merged 1 commit into from
Feb 5, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Feb 2, 2024 •
edited
Loading

Moves FakeCoordinator to tailnettest since it's reused in testing multiple packages in this stack of PRs.

@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Feb 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Feb 2, 2024
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review February 2, 2024 09:18
johnstcn
johnstcn approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move is fine, but see comment in #11991

@spikecurtis spikecurtis force-pushed the spike/fake-coordinator-rename branch from 149acdb to dbd0a93 Compare February 5, 2024 06:45
@spikecurtis spikecurtis force-pushed the spike/fake-coordinator-move branch from 02f29b5 to f39414c Compare February 5, 2024 06:45
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Feb 5, 2024 •
edited
Loading

Merge activity

  • Feb 5, 4:33 AM EST: @spikecurtis started a stack merge that includes this pull request via Graphite.
  • Feb 5, 4:34 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 5, 4:49 AM EST: @spikecurtis merged this pull request with Graphite.

Base automatically changed from spike/fake-coordinator-rename to main February 5, 2024 09:33
@spikecurtis spikecurtis force-pushed the spike/fake-coordinator-move branch from f39414c to 19806f6 Compare February 5, 2024 09:33
@spikecurtis spikecurtis merged commit bb99cb7 into main Feb 5, 2024
@spikecurtis spikecurtis deleted the spike/fake-coordinator-move branch February 5, 2024 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @johnstcn