Skip to content

fix: use dark background in terminal, even when a light theme is selected #12004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: use dark background in terminal, even when a light theme is selected #12004

merged 1 commit into from
Feb 2, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Feb 2, 2024 •
edited
Loading

Closes #11662

@aslilac aslilac requested a review from matifali February 2, 2024 21:01
matifali
matifali approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good workaround for now. Recently, I started using Ghostty, and there are algorithms that terminal programs use to do automatic contrast correction.

@aslilac
Copy link
Member Author

aslilac commented Feb 2, 2024

It's a good workaround for now. Recently, I started using Ghostty, and there are algorithms that terminal programs use to do automatic contrast correction.

one day we'll use ghostty as our web term and live in peace and harmony. this is not that day. :)

@aslilac aslilac merged commit 1d14d4e into main Feb 2, 2024
@aslilac aslilac deleted the force-dark-terminal branch February 2, 2024 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

light theme: web terminal white text on white background
2 participants
@aslilac @matifali