Skip to content

fix(site): fix infinity loading when template has no previous version #12059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #12053

@BrunoQuaresma BrunoQuaresma requested a review from a team February 7, 2024 17:47
@BrunoQuaresma BrunoQuaresma self-assigned this Feb 7, 2024
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team February 7, 2024 17:47
),
);

return result ?? null;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to do this because react-query does not allow queries to return undefined 😟

Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma BrunoQuaresma merged commit 4d63a47 into main Feb 7, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-source-files-without-diff branch February 7, 2024 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@BrunoQuaresma
Copy link
Collaborator Author

@Kira-Pilot I'm merging it now but let me know if you have any considerations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template 'source code' tab never shows source code if only one version exists
1 participant