docs: add steps for postgres server verification #12072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Feb 9, 2024
| @@ -222,7 +224,36 @@ coder: | |||
| 1. Lastly, your PG connection URL will look like: | |||
|
|
|||
| ```shell | |||
| postgres://<user>:<password>@databasehost:<port>/<db-name>?sslmode=require&sslcert=$HOME/.postgresql/postgres.crt&sslkey=$HOME/.postgresql/postgres.key" | |||
| postgres://<user>:<password>@databasehost:<port>/<db-name>?sslmode=require&sslcert="$HOME/.postgresql/postgres.crt&sslkey=$HOME/.postgresql/postgres.key" | |||
There was a problem hiding this comment.
@ericpaulsen, as this PG verification step is common to all installation methods, should it be refactored to a new section (advanced install)? It does not fit here in K8s.
Also, We should probably create a generic guide on creating a k8s secret and mounting it as a volume in the k8s pod and then refer to it within docs whenever we discuss mounting any k8s secrets.
cc: @coder/pms
There was a problem hiding this comment.
@matifali i agree - i can move this to a guide.
matifali
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our current docs on connecting to PostgreSQL over SSL is only for client verification (server verifying the client). a customer gave feedback on needing the server to be verified by the client (the Coder control plane, in this case).
this PR adds steps for the PG server verification.