feat: disable directory listings for static files #12229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static file server handles serving static asset files (js, css, etc). The default file server would also list all files in a directory. This has been changed to only serve files.
Emyrk
commented
Feb 20, 2024
| @@ -129,7 +130,15 @@ func New(opts *Options) *Handler { | |||
| // If-Match and If-None-Match headers on the request properly. | |||
| http.FileServer(opts.BinFS).ServeHTTP(rw, r) | |||
Comment on lines
-105
to
107
| // Serve the directory listing. | ||
| // Serve the directory listing. This intentionally allows directory listings to | ||
| // be served. This file system should not contain anything sensitive. | ||
| http.FileServer(opts.BinFS).ServeHTTP(rw, r) |
There was a problem hiding this comment.
It feels beneficial to keep this for listing what binaries are supported. Thoughts?
kylecarbs
approved these changes
Feb 20, 2024
Comment on lines
-105
to
107
| // Serve the directory listing. | ||
| // Serve the directory listing. This intentionally allows directory listings to | ||
| // be served. This file system should not contain anything sensitive. | ||
| http.FileServer(opts.BinFS).ServeHTTP(rw, r) |
Emyrk
commented
Feb 20, 2024
Comment on lines
12
to
22
| func FS() fs.FS { | ||
| return slim | ||
| // This is required to contain an index.html file for unit tests. | ||
| // Our unit tests frequently just hit `/` and expect to get a 200. | ||
| // So a valid index.html file should be expected to be served. | ||
| return fstest.MapFS{ | ||
| "index.html": &fstest.MapFile{ | ||
| Data: []byte("Slim build of Coder, does not contain the frontend static files."), | ||
| ModTime: time.Now(), | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
@kylecarbs I had to add this so unit tests work. When they query / it was a 404 since / was a directory, which now is not allowed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static file server handles serving static asset files (js, css, etc). The default file server would also list all files in a directory. This has been changed to only serve files.
Now directories return a 404
Closes #12235