fix: Unnest workspaces command to the top-level #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 65.98% 66.07% +0.08%
==========================================
Files 276 275 -1
Lines 17984 17949 -35
Branches 216 216
==========================================
- Hits 11867 11860 -7
+ Misses 4878 4852 -26
+ Partials 1239 1237 -2
Continue to review full report at Codecov.
|
coadler
approved these changes
May 2, 2022
cli/delete.go
Outdated
| @@ -10,12 +10,11 @@ import ( | |||
| "github.com/coder/coder/codersdk" | |||
| ) | |||
|
|
|||
| func workspaceDelete() *cobra.Command { | |||
| func deleteWS() *cobra.Command { | |||
There was a problem hiding this comment.
All of the other functions seem to have removed workspace references in the names. WS seems a bit ambiguous as well.
There was a problem hiding this comment.
One of our linters protects function names from being built-in keywords, but I'll just disable it for this case.
This changes all "coder workspace *" commands to root. A few of these were already at the root, like SSH. The inconsistency made for a confusing experience.
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This changes all "coder workspace *" commands to root. A few of these were already at the root, like SSH. The inconsistency made for a confusing experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all "coder workspace *" commands to root.
A few of these were already at the root, like SSH. The
inconsistency made for a confusing experience.