From 3bbd23591cff419fdf8410b31e301690c71e664c Mon Sep 17 00:00:00 2001 From: kylecarbs Date: Sun, 1 May 2022 18:43:42 +0000 Subject: [PATCH] fix: Disable ErrorLog in http.Server Vault does similarly: https://github.com/hashicorp/vault/blob/e2490059d0711635e529a4efcbaa1b26998d6e1c/command/server.go#L2714 These messages have primarily been noise. --- cli/server.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cli/server.go b/cli/server.go index 8becc46153ffe..68722f1a5e133 100644 --- a/cli/server.go +++ b/cli/server.go @@ -8,6 +8,8 @@ import ( "encoding/pem" "errors" "fmt" + "io" + "log" "net" "net/http" "net/url" @@ -263,7 +265,10 @@ func server() *cobra.Command { go func() { defer close(errCh) server := http.Server{ - Handler: handler, + // These errors are typically noise like "TLS: EOF". Vault does similar: + // https://github.com/hashicorp/vault/blob/e2490059d0711635e529a4efcbaa1b26998d6e1c/command/server.go#L2714 + ErrorLog: log.New(io.Discard, "", 0), + Handler: handler, BaseContext: func(_ net.Listener) context.Context { return shutdownConnsCtx },