Skip to content

chore: embed static files in debug builds #12449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

chore: embed static files in debug builds #12449

merged 2 commits into from
Mar 7, 2024

Conversation

deansheather
Copy link
Member

  • Add --debug flag to build_go.sh which disables optimizations
  • Change coder-dev.sh to use build_go.sh to build debugger binaries and use dlv exec to run the debugger

@johnstcn
Copy link
Member

johnstcn commented Mar 7, 2024

👍 This is what I should have done from the get-go

dannykopping
dannykopping approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@deansheather deansheather enabled auto-merge (squash) March 7, 2024 09:19
@deansheather deansheather merged commit bd752a6 into main Mar 7, 2024
@deansheather deansheather deleted the dean/delve-build-flags branch March 7, 2024 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deansheather @johnstcn @dannykopping