Skip to content

fix(site): allow triggering builds on non-dirtied template version in TemplateVersionEditor #12547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

johnstcn
Copy link
Member

Fixes #12545

#12406 added a feature to warn the user if they made changes to the template editor but also introduced new behaviour that disabled the Build button if no changes were made to the template source code. This PR restores the original behaviour.

@johnstcn johnstcn self-assigned this Mar 12, 2024
@johnstcn johnstcn changed the title fix(site): TemplateVersionEditor: allow triggering builds on non-dirtied template version fix(site): allow triggering builds on non-dirtied template version in TemplateVersionEditor Mar 12, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit edc465c into main Mar 12, 2024
@johnstcn johnstcn deleted the cj/ui-allow-building-non-dirty-templates branch March 12, 2024 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish and build buttons disabled in template editor
2 participants