fix: hide actions and notifications from deleted workspaces #12563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Mar 12, 2024
Parkreiner
approved these changes
Mar 13, 2024
Comment on lines
+109
to
+111
| const isImmutable = | ||
| workspace.latest_build.status === "deleted" || | ||
| workspace.latest_build.status === "deleting"; |
There was a problem hiding this comment.
Quick shout: we do still have logic in the WorkspacesActions component to handle the deletion statuses. I'm not sure if you saw that, but I actually think we should keep them, as a form of double-bookkeeping. Not sure what you think, though
There was a problem hiding this comment.
yeah, let's go with that. :) (it probably is helpful to make sure we don't regress in a big way)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12561
Don't bother showing the action buttons et al if the workspace has been deleted