Skip to content

fix(codersdk): abort in-progress writes/reads when closing websocket #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ammario
Copy link
Member

@ammario ammario commented Mar 18, 2024

Fixes #9203

Related #12065

Also, adds some basic tracing infrastructure that we can build upon for more improvements.

Copy link
Member Author

ammario commented Mar 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ammario and the rest of your teammates on Graphite Graphite

@ammario ammario requested a review from spikecurtis March 18, 2024 16:55
@ammario ammario marked this pull request as ready for review March 18, 2024 16:55
Fixes #9203

Also, adds some basic tracing infrastructure that we can build upon for
more improvements.
@ammario ammario requested review from coadler and removed request for spikecurtis March 20, 2024 16:51
@ammario ammario merged commit 0d86dca into main Mar 20, 2024
@ammario ammario deleted the cli-trace branch March 20, 2024 16:53
Copy link
Member Author

ammario commented Mar 20, 2024

Merge activity

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH super slow when startup script fails
2 participants