Skip to content

chore(coderd/workspaceapps/apptest): fix test flake due to concurrent usage of same deployment #12700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2024
Merged

chore(coderd/workspaceapps/apptest): fix test flake due to concurrent usage of same deployment #12700

merged 3 commits into from
Mar 21, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 21, 2024 •
edited
Loading

  • Updates existing tests under workspaceapps/apptest to not reuse existing appDetails as assertWorkspaceLastUsed(Not)?Updated calls FlushStats() which was causing racy test behaviour and incorrect test assertions.
  • Expands scope of assertWorkspaceLastUsedAtUpdated and its counterpart to ProxySubdomain tests.

@johnstcn johnstcn self-assigned this Mar 21, 2024
@johnstcn johnstcn requested review from Emyrk and mafredri March 21, 2024 12:48
@johnstcn johnstcn marked this pull request as ready for review March 21, 2024 12:48
@johnstcn
Copy link
Member Author

johnstcn commented Mar 21, 2024 •
edited
Loading 

create db with template:
  github.com/coder/coder/v2/coderd/database/postgres.Open
    /home/runner/actions-runner/_work/coder/coder/coderd/database/postgres/postgres.go:41
  - pq: could not write to file "base/35912/17659": No space left on device

🏆

EDIT: #12702

@johnstcn johnstcn merged commit 8ea5fb7 into main Mar 21, 2024
@johnstcn johnstcn deleted the cj/flake-WorkspaceApps branch March 21, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@deansheather deansheather deansheather approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @Emyrk @deansheather