Skip to content

chore: clean up databases after test finishes in CI #12702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 21, 2024

  • Moves postgres.Open and friends to dbtestutil as that is the only place they're used
  • Adds logic to DROP CI databases when we're done with them otherwise our DB container can fill up

Reduces make test-postgres memory usage from ~16GB down to approx. 2.3GB

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great reduction in memory consumption. 👍

@johnstcn johnstcn changed the title chore(ci): clean up databases after test finishes in CI chore: clean up databases after test finishes in CI Mar 21, 2024
@johnstcn johnstcn merged commit 5454f49 into main Mar 21, 2024
@johnstcn johnstcn deleted the cj/dbtestutil-cleanup-ci branch March 21, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants