Skip to content

ci: disable --in-memory for enterprise e2e tests #12874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2024
Merged

ci: disable --in-memory for enterprise e2e tests #12874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492c9d5
ci: disable `--in-memory` for enterprise e2e tests
aslilac Apr 4, 2024
c99448d
remove enterprise e2e tests from ci job temporarily
aslilac Apr 4, 2024
9fb9963
not needed
aslilac Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,13 +478,6 @@ jobs:
DEBUG: pw:api
working-directory: site

# Run all of the tests with an enterprise license
- run: pnpm playwright:test --forbid-only --workers 1
env:
DEBUG: pw:api
CODER_E2E_ENTERPRISE_LICENSE: ${{ secrets.CODER_E2E_ENTERPRISE_LICENSE }}
working-directory: site

- name: Upload Playwright Failed Tests
if: always() && github.actor != 'dependabot[bot]' && runner.os == 'Linux' && !github.event.pull_request.head.repo.fork
uses: actions/upload-artifact@v4
Expand Down
35 changes: 23 additions & 12 deletions site/e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { defineConfig } from "@playwright/test";
import * as path from "path";
import { coderMain, coderPort, coderdPProfPort, gitAuth } from "./constants";
import {
coderMain,
coderPort,
coderdPProfPort,
enterpriseLicense,
gitAuth,
} from "./constants";

export const wsEndpoint = process.env.CODER_E2E_WS_ENDPOINT;

Expand Down Expand Up @@ -43,17 +49,22 @@ export default defineConfig({
},
webServer: {
url: `http://localhost:${coderPort}/api/v2/deployment/config`,
command:
`go run -tags embed ${coderMain} server ` +
`--global-config $(mktemp -d -t e2e-XXXXXXXXXX) ` +
`--access-url=http://localhost:${coderPort} ` +
`--http-address=localhost:${coderPort} ` +
`--in-memory --telemetry=false ` +
`--dangerous-disable-rate-limits ` +
`--provisioner-daemons 10 ` +
`--provisioner-daemons-echo ` +
`--web-terminal-renderer=dom ` +
`--pprof-enable`,
command: [
`go run -tags embed ${coderMain} server`,
"--global-config $(mktemp -d -t e2e-XXXXXXXXXX)",
`--access-url=http://localhost:${coderPort}`,
`--http-address=localhost:${coderPort}`,
// Adding an enterprise license causes issues with pgcoord when running with `--in-memory`.
!enterpriseLicense && "--in-memory",
"--telemetry=false",
"--dangerous-disable-rate-limits",
"--provisioner-daemons 10",
"--provisioner-daemons-echo",
"--web-terminal-renderer=dom",
"--pprof-enable",
]
.filter(Boolean)
.join(" "),
env: {
...process.env,

Expand Down
2 changes: 1 addition & 1 deletion site/e2e/tests/updateTemplate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ test("add and remove a group", async ({ page }) => {

// Now remove the group
await row.getByLabel("More options").click();
await page.getByText("Delete").click();
await page.getByText("Remove").click();
await expect(page.getByText("Group removed successfully!")).toBeVisible();
await expect(row).not.toBeVisible();
});
Expand Down