Skip to content

fix(install.sh): change post-install advisory when installing specific version #12878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix(install.sh): change post-install advisory when installing specific version #12878

merged 1 commit into from
Apr 5, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Apr 5, 2024

This is a continuation of #12873 to fully support --version flag.

❯ cat install.sh | sh -s -- --method=standalone --version 2.9.0
[...]
Coder release v2.9.0 installed. To install our stable release (v2.9.1), use the --stable flag. See our releases documentation or GitHub for more information on versioning.
[...]

❯ cat install.sh | sh -s -- --method=standalone --version 2.9.1
[...]
Coder stable release v2.9.1 installed. See our releases documentation or GitHub for more information on versioning.
[...]

@mafredri mafredri requested review from mtojek and stirby April 5, 2024 11:37
@mafredri
Copy link
Member Author

mafredri commented Apr 5, 2024

@michaelbrewer FYI, this is the improvement I had in mind.

@mafredri mafredri added the hotfix label Apr 5, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Apr 5, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri
Copy link
Member Author

mafredri commented Apr 5, 2024

Looks like we introduced an unbound variable check in #12873, merging this as a hotfix now. Feel free to post-review.

@mafredri mafredri merged commit c243210 into main Apr 5, 2024
@mafredri mafredri deleted the mafredri/fix-install.sh-advisory-for-specific-version branch April 5, 2024 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
mtojek
mtojek reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@stirby stirby Awaiting requested review from stirby

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek