chore: nix shell to support playwright e2e tests #12917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix is running an older version of chromium, so had to reduce the playwright version.
aslilac
approved these changes
Apr 10, 2024
| @@ -20,3 +20,26 @@ pnpm playwright:test | |||
| # Run a specific test (`-g` stands for grep. It accepts regex). | |||
| pnpm playwright:test -g '<your test here>' | |||
| ``` | |||
|
|
|||
| # Using nix | |||
There was a problem hiding this comment.
I think it's probably worth linking to https://search.nixos.org/packages?channel=unstable&type=packages&query=playwright-driver somewhere in this section as a quick way to figure out what the "right" Playwright version is
|
I bet we could even write a script that gets the version number from nixpkgs, and runs |
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
That would be very cool. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nix is running an older version of chromium, so had to reduce the playwright version.