Skip to content

fix: ignore gomock temporary files #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: ignore gomock temporary files #12924

merged 2 commits into from
Apr 10, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 10, 2024

Spotted in: #12508

This PR adds a tiny .gitignore file to skip gomock_* resources left in the workspace if tests are interrupted.

@mtojek mtojek self-assigned this Apr 10, 2024
@mtojek mtojek marked this pull request as ready for review April 10, 2024 08:41
@mtojek mtojek added the hotfix label Apr 10, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Apr 10, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mtojek mtojek enabled auto-merge (squash) April 10, 2024 08:45
@mtojek mtojek merged commit b6359b0 into main Apr 10, 2024
26 checks passed
@mtojek mtojek deleted the fix-gomock-tailnettest branch April 10, 2024 08:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtojek