Skip to content

feat: specify a custom "terms of service" link #13068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2024
Merged

feat: specify a custom "terms of service" link #13068

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
331f8a4
feat: specify a custom terms of service link
aslilac Apr 24, 2024
8f03a45
require check
aslilac Apr 24, 2024
0b8ae10
noreferrer
aslilac Apr 24, 2024
d3ec782
bep
aslilac Apr 25, 2024
107d355
tweaks
aslilac Apr 25, 2024
1d3c010
`make gen`
aslilac Apr 25, 2024
e8550dc
url
aslilac Apr 25, 2024
43f20ea
i like
aslilac Apr 25, 2024
a06ddc2
`make update-golden-files`
aslilac Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
noreferrer
  • Loading branch information
@aslilac
aslilac committed Apr 24, 2024
commit 0b8ae102f798f00e4e20a28ecc79ad00356de19e
6 changes: 5 additions & 1 deletion site/src/pages/LoginPage/SignInForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Interpolation, Theme } from "@emotion/react";
import Checkbox from "@mui/material/Checkbox";

Check failure on line 2 in site/src/pages/LoginPage/SignInForm.tsx

View workflow job for this annotation

GitHub Actions / fmt 

'@mui/material' import is restricted from being used. Use path imports to avoid pulling in unused modules. See: https://material-ui.com/guides/minimizing-bundle-size/
import { type FC, type ReactNode, useState } from "react";
import type { AuthMethods } from "api/typesGenerated";
import { Alert } from "components/Alert/Alert";
Expand All @@ -7,7 +7,7 @@
import { getApplicationName } from "utils/appearance";
import { OAuthSignInForm } from "./OAuthSignInForm";
import { PasswordSignInForm } from "./PasswordSignInForm";
import { Link } from "@mui/material";

Check failure on line 10 in site/src/pages/LoginPage/SignInForm.tsx

View workflow job for this annotation

GitHub Actions / lint 

'@mui/material' import is restricted from being used. Use path imports to avoid pulling in unused modules. See: https://material-ui.com/guides/minimizing-bundle-size/

Check failure on line 10 in site/src/pages/LoginPage/SignInForm.tsx

View workflow job for this annotation

GitHub Actions / lint 

`@mui/material` import should occur before import of `@mui/material/Checkbox`

Check failure on line 10 in site/src/pages/LoginPage/SignInForm.tsx

View workflow job for this annotation

GitHub Actions / lint 

'@mui/material' import is restricted from being used. Use path imports to avoid pulling in unused modules. See: https://material-ui.com/guides/minimizing-bundle-size/

Check failure on line 10 in site/src/pages/LoginPage/SignInForm.tsx

View workflow job for this annotation

GitHub Actions / lint 

`@mui/material` import should occur before import of `@mui/material/Checkbox`

export const Language = {
emailLabel: "Email",
Expand Down Expand Up @@ -142,7 +142,11 @@
onChange={(event) => setTosAccepted(event.target.checked)}
/>
I agree to the{" "}
<Link href={authMethods.terms_of_service_link} target="_blank">
<Link
href={authMethods.terms_of_service_link}
target="_blank"
rel="noreferrer"
>
Terms of Service
</Link>
.
Expand Down
Loading