Skip to content

chore: enable terraform provisioners in e2e by default #13134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 8, 2024
Merged

chore: enable terraform provisioners in e2e by default #13134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c810759
make gen
Emyrk May 1, 2024
5294740
add icon to health provisioner page for prov type
Emyrk May 1, 2024
ae89373
update golden files
Emyrk May 1, 2024
e12e721
update golden files
Emyrk May 1, 2024
f4dbfb5
make gen
Emyrk May 2, 2024
2a09af3
update golden files
Emyrk May 2, 2024
736df67
remove ui pills for provisioners on health page
Emyrk May 2, 2024
f104148
remove unused import
Emyrk May 2, 2024
e82b2c3
chore: terraform provisioners enabled in e2e by default
Emyrk May 2, 2024
de3f81d
fixup config
Emyrk May 2, 2024
8fdaf2c
begin work on terraform e2e test
Emyrk May 2, 2024
f4d7c0d
update import order
Emyrk May 2, 2024
50501e8
create e2e terraform test with docker template
Emyrk May 3, 2024
c25f6c4
Run docker e2e in CI once
Emyrk May 3, 2024
604227e
disable leaky test
Emyrk May 3, 2024
f5e09cd
fixup hidden input field
Emyrk May 3, 2024
3862311
remove comments
Emyrk May 3, 2024
3173a5e
switch to query params
Emyrk May 5, 2024
fca5946
imports
Emyrk May 5, 2024
d9a8dc7
remove diff
Emyrk May 5, 2024
e34546f
PR suggestions, using web terminal helper
Emyrk May 7, 2024
ab2c29f
PR feedback on executable errors
Emyrk May 7, 2024
c521532
rename require
Emyrk May 8, 2024
2b77082
skip docker test, it leaks containers
Emyrk May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename require
  • Loading branch information
@Emyrk
Emyrk committed May 8, 2024
commit c521532dfe61f1f3b85e33f40b86dc841dbef63b
4 changes: 2 additions & 2 deletions site/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export function requiresEnterpriseLicense() {
test.skip(!enterpriseLicense);
}

// requiresTerraform by default is enabled.
export function requiresTerraform() {
// requireTerraformProvisioner by default is enabled.
export function requireTerraformProvisioner() {
test.skip(!requireTerraformTests);
}

Expand Down
4 changes: 2 additions & 2 deletions site/e2e/tests/createWorkspace.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
createWorkspace,
echoResponsesWithParameters,
openTerminalWindow,
requiresTerraform,
requireTerraformProvisioner,
verifyParameters,
} from "../helpers";
import { beforeCoderTest } from "../hooks";
Expand Down Expand Up @@ -156,7 +156,7 @@ test("create docker workspace", async ({ context, page }) => {
// true,
// "creating docker containers is currently leaky. They are not cleaned up when the tests are over.",
// );
requiresTerraform();
requireTerraformProvisioner();
const template = await createTemplate(page, StarterTemplates.STARTER_DOCKER);

const workspaceName = await createWorkspace(page, template);
Expand Down
Loading