Skip to content

chore: remove superfluous context.Canceled handling #13140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented May 3, 2024

Removes a check for context.Canceled inside the handleManifest routine. This checking is handled in the apiConnRoutineManager, so checking inside the handler is redundant.

Copy link
Contributor Author

@spikecurtis spikecurtis force-pushed the spike/13139-superfluous-ctx branch from 2a73bb4 to 49cee21 Compare May 6, 2024 10:22
@spikecurtis spikecurtis merged commit 2efb46a into main May 6, 2024
25 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/13139-superfluous-ctx branch May 6, 2024 10:33
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants