Skip to content

test(coderd/database): fix DST issue in dbpurge test #13170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented May 6, 2024

Database runs in Canada/Newfoundland, DST change was at Nov 3 and we perform a lookback of 7 months with suggests the issue started after the DST change.

Fixes #13165

Copy link
Member Author

mafredri commented May 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mafredri and the rest of your teammates on Graphite Graphite

@mafredri mafredri requested review from coadler and mtojek May 6, 2024 10:31
@mafredri mafredri marked this pull request as ready for review May 6, 2024 10:31
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mafredri mafredri merged commit 619ec92 into main May 6, 2024
32 checks passed
@mafredri mafredri deleted the mafredri/05-06-test_coderd_database_fix_dst_issue_in_dbpurge_test branch May 6, 2024 11:14
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test flake: coderd/database/dbpurge TestDeleteOldWorkspaceAgentStats
2 participants