Skip to content

feat: use latest gVisor and go 1.22.3 #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 23, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented May 22, 2024

Updates Coder to use the latest gVisor release, which includes HyStart for TCP.

Updates other packages that also depend on gVisor like wireguard-go and tailscale to our forks, updated to work with latest gVisor (which has some small API changes).

Fixes #12801
Fixes #12803

As gVisor was the package that prevented us from updating to go 1.22, this PR also updates us to use go 1.22.

Fixes #11342

One consequence of go 1.22 is that TLS_RSA_WITH_AES_128_GCM_SHA256 is marked as an insecure cipher. It's replaced with TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 in the unit test referencing it.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review May 22, 2024 05:43
@spikecurtis spikecurtis force-pushed the 05-22-feat_use_latest_gvisor_and_go_1.22.3 branch from d55c978 to c811d67 Compare May 22, 2024 05:56
@matifali
Copy link
Member

Should this also close #11342?

@spikecurtis spikecurtis force-pushed the 05-22-feat_use_latest_gvisor_and_go_1.22.3 branch from c811d67 to 13c2486 Compare May 22, 2024 10:09
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kylecarbs kylecarbs merged commit b43344b into main May 23, 2024
37 of 39 checks passed
@kylecarbs kylecarbs deleted the 05-22-feat_use_latest_gvisor_and_go_1.22.3 branch May 23, 2024 12:22
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

point coder at the gVisor with HyStart change coder to import new wgtunnel Support Go 1.22
4 participants