Skip to content

chore: upgrade go.uber.org/goleak #13388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

chore: upgrade go.uber.org/goleak #13388

merged 1 commit into from
May 28, 2024

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 28, 2024

The latest published version is broken on go 1.20

@coadler Graphite App
Copy link
Contributor Author

coadler commented May 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @coadler and the rest of your teammates on Graphite Graphite

@coadler coadler force-pushed the colin/chore_upgrade_go.uber.org_goleak_ branch from e09af79 to 4011402 Compare May 28, 2024 21:54
@coadler coadler added the hotfix PRs only. Harmless small change. Only humans may set this. label May 28, 2024 — with Graphite App
@coadler coadler marked this pull request as ready for review May 28, 2024 21:54
cdr-bot[bot]
cdr-bot bot approved these changes May 28, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@coadler coadler force-pushed the colin/chore_upgrade_go.uber.org_goleak_ branch from 4011402 to f89fd92 Compare May 28, 2024 21:58
@coadler
chore: upgrade go.uber.org/goleak
5aa7984 
The latest published version is broken on go 1.20
@coadler coadler force-pushed the colin/chore_upgrade_go.uber.org_goleak_ branch from f89fd92 to 5aa7984 Compare May 28, 2024 22:05
@coadler coadler merged commit 02c3686 into main May 28, 2024
28 of 29 checks passed
@coadler coadler deleted the colin/chore_upgrade_go.uber.org_goleak_ branch May 28, 2024 22:15
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@coadler coadler

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @kylecarbs