Skip to content

ci: build base image on PRs #13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2024
Merged

ci: build base image on PRs #13409

merged 4 commits into from
May 30, 2024

Conversation

matifali
Copy link
Member

This will prevent events like #13407 in future.

@ammario @kylecarbs, we should probably also mark this as a required workflow.

@matifali
ci: builld base image on PRs
8cad26c 
This will prevent events like #13407 in future.

@ammario @kylecarbs, we should probably also mark this as a required workflow.
@matifali matifali requested a review from deansheather May 30, 2024 08:09
@matifali matifali requested review from kylecarbs and coadler May 30, 2024 08:09
@matifali matifali changed the title ci: builld base image on PRs ci: build base image on PRs May 30, 2024
deansheather

This comment was marked as resolved.

Sign in to view

@matifali
fixup!
5e05a5e 
Do not push on `pull_request`
@matifali matifali requested a review from deansheather May 30, 2024 08:14
dannykopping
dannykopping approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocking my preview deployment as well, it seems: https://github.com/coder/coder/actions/runs/9299191579/job/25592636303

@matifali
Copy link
Member Author

This is blocking my preview deployment as well, it seems: coder/coder/actions/runs/9299191579/job/25592636303

@dannykopping for this, we need to solve #13407. This PR will only prevent this in the future.

@matifali matifali enabled auto-merge (squash) May 30, 2024 08:29
@matifali matifali mentioned this pull request May 30, 2024
Merged
@dannykopping
Copy link
Contributor

This is blocking my preview deployment as well, it seems: coder/coder/actions/runs/9299191579/job/25592636303

@dannykopping for this, we need to solve #13407. This PR will only prevent this in the future.

Let's see if #13411 fixes it.

@matifali matifali merged commit 6730c24 into main May 30, 2024
24 checks passed
@matifali matifali deleted the build-base-on-pr branch May 30, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@dannykopping
Copy link
Contributor

@matifali seems related? https://github.com/coder/coder/actions/runs/9299566996/job/25593744921

@dannykopping
Copy link
Contributor

If you don't already, I'd suggest testing workflows with https://github.com/nektos/act

@matifali
Copy link
Member Author

@dannykopping Yes. Looking into it. Sorry for not testing it.

@dannykopping
Copy link
Contributor

No prob, let's revert in the interim pls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@deansheather deansheather deansheather approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@coadler coadler Awaiting requested review from coadler

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @dannykopping @deansheather