fix: replace invalid utf-8 sequences in agent logs #13436
Conversation
|
Is it possible to backport this to stable branch? We are facing this error in production too. Coder Version v2.10.3 |
codersdk/agentsdk/convert.go
Outdated
| @@ -348,7 +348,7 @@ func ProtoFromLog(log Log) (*proto.Log, error) { | |||
| } | |||
| return &proto.Log{ | |||
| CreatedAt: timestamppb.New(log.CreatedAt), | |||
| Output: log.Output, | |||
| Output: strings.ToValidUTF8(log.Output, ""), | |||
There was a problem hiding this comment.
I think we should probably replace invalid utf-8 with something, so it's obvious data is being deleted.
There was a problem hiding this comment.
Should we get cute and replace with something like ❌ or 😞 or 🤬, or just something like <<invalid UTF-8>>?
Signed-off-by: Spike Curtis <spike@coder.com>
|
Decided to just be bold and add the regression test and replacement with ❌ --- @coadler @kylecarbs revert me if you disagree. |
@MrPeacockNLB I think our policy for fixes unrelated to security is to backport to stable, which is 2.11 as of today. |
Fixes #13433.