Skip to content

feat(coderd): set full name from IDP name claim #13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 6, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 4, 2024

Part of #11704

  • Updates OIDC and GitHub OAuth login to fetch set name from relevant claim fields
  • Adds CODER_OIDC_NAME_FIELD as configurable source of user name claim
  • Adds httpapi function to normalize a username such that it will pass validation
  • Adds firstName / lastName fields to dev OIDC setup

Screenshots:

  1. Post-OIDC login:
    Screenshot 2024-06-06 at 11 39 20

  2. OIDC claims from DB:
    Screenshot 2024-06-06 at 11 49 54

NOTE: does not update "first-time setup" in the UI to allow setting username. This will be done in a separate PR.

@johnstcn johnstcn self-assigned this Jun 4, 2024
@johnstcn johnstcn changed the title [WIP] feat(coderd): set full name from IDP feat(coderd): set full name from IDP name claim Jun 6, 2024
@johnstcn johnstcn marked this pull request as ready for review June 6, 2024 10:53
@johnstcn johnstcn requested review from mtojek, Emyrk and dannykopping and removed request for mtojek June 6, 2024 10:53
@johnstcn johnstcn merged commit 1131772 into main Jun 6, 2024
31 checks passed
@johnstcn johnstcn deleted the cj/idp-fullname branch June 6, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants