Skip to content

chore!: remove deprecated agent v1 routes #13486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jun 6, 2024

This breaks compatibility with older agents that don't use API v2

Closes #10530

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson changed the title chore: remove deprecated agent v1 routes chore!: remove deprecated agent v1 routes Jun 6, 2024
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good so far, but the metricscollector_test should be added back

@ethanndickson ethanndickson marked this pull request as ready for review June 6, 2024 15:54
@deansheather deansheather self-requested a review June 8, 2024 11:32
@ethanndickson ethanndickson merged commit dd24368 into main Jun 11, 2024
29 of 31 checks passed
@ethanndickson ethanndickson deleted the 06-06-chore_remove_deprecated_agent_v1_routes branch June 11, 2024 02:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@f0ssel
Copy link
Contributor

f0ssel commented Jun 14, 2024

FYI we probably need to mention this removal in the release docs @coder/pms

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Agent API v2 Support to Coderd
3 participants