Skip to content

chore(cli): address cli netcheck test flake #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 6, 2024

Fixes #13489

  • Removed the check for a healthy node report. At this stage, we're not interested in whether the report is healthy or not, but that it contains the correct number of node reports.
  • In derphealth, we hard-code a 10-second deadline when running a NodeReport. Modified to only set a deadline if none is already set on the parent context.

@johnstcn johnstcn merged commit 48ecee1 into main Jun 7, 2024
27 checks passed
@johnstcn johnstcn deleted the cj/flake/cli-healthcheck branch June 7, 2024 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestNetcheck: timeout reading from 127.0.0.1
2 participants