Skip to content

fix(site): fix tooltip in start button group #13497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix(site): fix tooltip in start button group #13497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(site): fix tooltip in start button group
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jun 6, 2024
commit 4c11d21f3a5ee7fafa7076c46d4ac147ca6c092c
30 changes: 16 additions & 14 deletions site/src/pages/WorkspacePage/WorkspaceActions/Buttons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,21 @@ export const StartButton: FC<ActionButtonPropsWithWorkspace> = ({
disabled,
tooltipText,
}) => {
const buttonContent = (
let mainButton = (
<TopbarButton
startIcon={<PlayCircleOutlineIcon />}
onClick={() => handleAction()}
disabled={disabled || loading}
>
{loading ? <>Starting&hellip;</> : "Start"}
</TopbarButton>
);

if (tooltipText) {
mainButton = <Tooltip title={tooltipText}>{mainButton}</Tooltip>;
}

return (
<ButtonGroup
variant="outlined"
sx={{
Expand All @@ -74,13 +88,7 @@ export const StartButton: FC<ActionButtonPropsWithWorkspace> = ({
}}
disabled={disabled}
>
<TopbarButton
startIcon={<PlayCircleOutlineIcon />}
onClick={() => handleAction()}
disabled={disabled || loading}
>
{loading ? <>Starting&hellip;</> : "Start"}
</TopbarButton>
{mainButton}
<BuildParametersPopover
label="Start with build parameters"
workspace={workspace}
Expand All @@ -89,12 +97,6 @@ export const StartButton: FC<ActionButtonPropsWithWorkspace> = ({
/>
</ButtonGroup>
);

return tooltipText ? (
<Tooltip title={tooltipText}>{buttonContent}</Tooltip>
) : (
buttonContent
);
};

export const StopButton: FC<ActionButtonProps> = ({
Expand Down
Loading