Skip to content

feat: Add endpoint to get all workspaces a user can access #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

feat: Add endpoint to get all workspaces a user can access #1354

merged 1 commit into from
May 10, 2022

Conversation

kylecarbs
Copy link
Member

This iterates through user organizations to get permitted
workspaces. This will allow admins to manage user workspaces!

@kylecarbs kylecarbs requested a review from coadler May 10, 2022 00:48
@kylecarbs kylecarbs self-assigned this May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #1354 (49be7c5) into main (3660483) will decrease coverage by 0.30%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   67.03%   66.73%   -0.31%     
==========================================
  Files         284      284              
  Lines       18529    18614      +85     
  Branches      235      235              
==========================================
+ Hits        12421    12422       +1     
- Misses       4844     4925      +81     
- Partials     1264     1267       +3
Flag Coverage Δ
unittest-go-macos-latest 53.96% <8.33%> (-0.31%) ⬇️
unittest-go-postgres- 65.34% <8.33%> (-0.39%) ⬇️
unittest-go-ubuntu-latest 56.40% <8.33%> (-0.24%) ⬇️
unittest-go-windows-2022 52.28% <8.33%> (-0.24%) ⬇️
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
coderd/database/queries.sql.go 76.73% <0.00%> (-1.42%) ⬇️
coderd/users.go 58.40% <0.00%> (-3.35%) ⬇️
codersdk/users.go 64.40% <50.00%> (-0.78%) ⬇️
coderd/coderd.go 94.55% <100.00%> (+0.02%) ⬆️
peer/conn.go 80.34% <0.00%> (-2.22%) ⬇️
coderd/workspaceagents.go 56.04% <0.00%> (-1.87%) ⬇️
provisionerd/provisionerd.go 75.90% <0.00%> (-0.41%) ⬇️
cli/server.go 57.48% <0.00%> (-0.10%) ⬇️
peerbroker/listen.go 87.39% <0.00%> (ø)
coderd/provisionerdaemons.go 63.48% <0.00%> (+0.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3660483...49be7c5. Read the comment docs.

coadler
coadler approved these changes May 10, 2022
View reviewed changes
go.mod
@@ -56,6 +56,7 @@ require (
github.com/fatedier/frp v0.42.0
github.com/fatedier/golib v0.1.1-0.20220321042308-c306138b83ac
github.com/fatih/color v1.13.0
github.com/fatih/structs v1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie, i mightve forgotten to go mod tidy. we should have a ci step for this, i'll do it in a bit

cmd/templater/main.go
@@ -1,279 +0,0 @@
package main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this is unrelated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but figured I'd clean it up in here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, makes sense

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Figured it was easier to remove this here. It hasn't been used in forever, and is kinda sketchy code.

@kylecarbs
feat: Add endpoint to get all workspaces a user can access
49be7c5 
This iterates through user organizations to get permitted
workspaces. This will allow admins to manage user workspaces!
@kylecarbs kylecarbs enabled auto-merge (squash) May 10, 2022 02:23
@kylecarbs kylecarbs merged commit b675aec into main May 10, 2022
@kylecarbs kylecarbs deleted the workspaces branch May 10, 2022 02:38
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
feat: Add endpoint to get all workspaces a user can access (#1354)
3c8ef64 
This iterates through user organizations to get permitted
workspaces. This will allow admins to manage user workspaces!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @coadler @misskniss