Skip to content

chore: implement api layer for listing organization members #13546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

chore: implement api layer for listing organization members #13546

merged 1 commit into from
Jun 12, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 11, 2024

No description provided.

@Emyrk Emyrk mentioned this pull request Jun 11, 2024
Merged
@Emyrk Graphite App
Copy link
Member Author

Emyrk commented Jun 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Emyrk and the rest of your teammates on Graphite Graphite

@Emyrk Emyrk force-pushed the stevenmasley/org_member_db branch from e2b5ca2 to 8b1bc7f Compare June 11, 2024 20:57
@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch 2 times, most recently from 65d1557 to d52c516 Compare June 12, 2024 14:25
@Emyrk Emyrk force-pushed the stevenmasley/org_member_db branch from ade54e1 to b98d06b Compare June 12, 2024 14:32
@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch from d52c516 to c757e52 Compare June 12, 2024 14:32
@Emyrk Emyrk marked this pull request as ready for review June 12, 2024 14:40
@Emyrk Emyrk mentioned this pull request Jun 12, 2024
Merged
@Emyrk Emyrk requested a review from f0ssel June 12, 2024 16:49
@Emyrk Emyrk mentioned this pull request Jun 12, 2024
Merged
f0ssel
f0ssel approved these changes Jun 12, 2024
View reviewed changes
coderd/members_test.go Outdated

client, user := coderdtest.CreateAnotherUser(t, owner, first.OrganizationID, rbac.ScopedRoleOrgAdmin(first.OrganizationID))

ctx := testutil.Context(t, testutil.WaitLong)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need wait long here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I'll reduce

@Emyrk Emyrk force-pushed the stevenmasley/org_member_db branch from b98d06b to 2542dcd Compare June 12, 2024 18:38
@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch 2 times, most recently from 45d4ff7 to 08e4131 Compare June 12, 2024 18:49
Base automatically changed from stevenmasley/org_member_db to main June 12, 2024 19:23
@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch from 08e4131 to ce4b854 Compare June 12, 2024 19:26
@Emyrk Emyrk merged commit bbe23ed into main Jun 12, 2024
31 checks passed
@Emyrk Emyrk deleted the stevenmasley/org_member_api branch June 12, 2024 19:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f0ssel f0ssel f0ssel approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @f0ssel