From 5194d100355244de2e587bd2703299e08d49d409 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Wed, 12 Jun 2024 11:01:39 +0200 Subject: [PATCH 1/3] feat: lint github actions workflows Signed-off-by: Danny Kopping --- .github/workflows/ci.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 850c8f0c6d238..d989a54580a78 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -191,6 +191,12 @@ jobs: run: | make --output-sync=line -j lint + - name: Check workflow files + run: | + bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) + ./actionlint -color -shellcheck= -ignore "set-output" + shell: bash + gen: timeout-minutes: 8 runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }} From 0423938801893beda36bc04b9ca07d3ba95b15a2 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Wed, 12 Jun 2024 14:02:44 +0200 Subject: [PATCH 2/3] Conditionally using buildjet like in other workflows Signed-off-by: Danny Kopping --- .github/workflows/nightly-gauntlet.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly-gauntlet.yaml b/.github/workflows/nightly-gauntlet.yaml index 592abe921c013..8f5016e122ab9 100644 --- a/.github/workflows/nightly-gauntlet.yaml +++ b/.github/workflows/nightly-gauntlet.yaml @@ -11,7 +11,7 @@ jobs: # While GitHub's toaster runners are likelier to flake, we want consistency # between this environment and the regular test environment for DataDog # statistics and to only show real workflow threats. - runs-on: "buildjet-8vcpu-ubuntu-2204" + runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }} # This runner costs 0.016 USD per minute, # so 0.016 * 240 = 3.84 USD per run. timeout-minutes: 240 @@ -40,7 +40,7 @@ jobs: go-timing: # We run these tests with p=1 so we don't need a lot of compute. - runs-on: "buildjet-2vcpu-ubuntu-2204" + runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-2vcpu-ubuntu-2204' || 'ubuntu-latest' }} timeout-minutes: 10 steps: - name: Checkout From b613ba040eb7fca7781b30e1cef4c7b359df33bc Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Wed, 26 Jun 2024 10:11:51 +0200 Subject: [PATCH 3/3] Pin to v1.6.22 Signed-off-by: Danny Kopping --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index d5e3821d4d724..59496b017d886 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -193,7 +193,7 @@ jobs: - name: Check workflow files run: | - bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) + bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) 1.6.22 ./actionlint -color -shellcheck= -ignore "set-output" shell: bash