Skip to content

fix: Use proper endpoint for user workspaces #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

fix: Use proper endpoint for user workspaces #1356

merged 1 commit into from
May 10, 2022

Conversation

kylecarbs
Copy link
Member

This was a silly mistake in a prior PR, so the code wasn't
actually being called!

@kylecarbs
fix: Use proper endpoint for user workspaces
407fbd4 
This was a silly mistake in a prior PR, so the code wasn't
actually being called!
@kylecarbs kylecarbs requested a review from coadler May 10, 2022 03:00
@kylecarbs kylecarbs self-assigned this May 10, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) May 10, 2022 03:01
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #1356 (407fbd4) into main (b675aec) will increase coverage by 0.06%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   66.69%   66.76%   +0.06%     
==========================================
  Files         284      280       -4     
  Lines       18614    18433     -181     
  Branches      235      235              
==========================================
- Hits        12414    12306     -108     
+ Misses       4931     4861      -70     
+ Partials     1269     1266       -3
Flag Coverage Δ
unittest-go-macos-latest 54.05% <69.56%> (+0.17%) ⬆️
unittest-go-postgres- 65.41% <69.56%> (+0.02%) ⬆️
unittest-go-ubuntu-latest 56.47% <69.56%> (+0.17%) ⬆️
unittest-go-windows-2022 ?
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
coderd/users.go 60.63% <68.18%> (+2.23%) ⬆️
coderd/coderd.go 94.55% <100.00%> (ø)
cli/configssh.go 62.58% <0.00%> (-6.48%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
coderd/workspaceagents.go 56.04% <0.00%> (-1.87%) ⬇️
agent/agent.go 64.66% <0.00%> (-1.86%) ⬇️
peer/channel.go 84.21% <0.00%> (-1.76%) ⬇️
peer/conn.go 78.37% <0.00%> (-1.72%) ⬇️
coderd/organizations.go 56.15% <0.00%> (-0.55%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b675aec...407fbd4. Read the comment docs.

@kylecarbs kylecarbs merged commit dc115b8 into main May 10, 2022
@kylecarbs kylecarbs deleted the fixws branch May 10, 2022 03:10
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Use proper endpoint for user workspaces (#1356)
af2e809 
This was a silly mistake in a prior PR, so the code wasn't
actually being called!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @coadler @misskniss