fix: remove assigning org-member role, this is implied from membership #13578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Jun 21, 2024
Comment on lines
98
to
101
| // TODO: When organizations are allowed to be created, we should | ||
| // come back to determining the default role of the person who | ||
| // creates the org. Until that happens, all users in an organization | ||
| // should be just regular members. |
There was a problem hiding this comment.
What about this TODO item? Out of scope?
There was a problem hiding this comment.
Yup out of scope. No one has requested this yet, but I imagine with custom roles it'll be asked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
organization-memberis implied here:coder/coderd/database/queries/users.sql
Lines 234 to 237 in 635b041
Remove manually setting it, because it is impossible to remove this role. This only affects the first user, so only 1 user per deployment has this role manually assigned. This is not a big deal, and can be ignored.