fix: fill out zero-value user properties in /audit #13604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf85f1d to
5055300
Compare
5055300 to
cb386a0
Compare
Emyrk
reviewed
Jun 20, 2024
Comment on lines
+6
to
+7
| -- sqlc.embed(users) would be nice but it does not seem to play well with | ||
| -- left joins. |
There was a problem hiding this comment.
Yea, there is a few issues open on this:
https://github.com/sqlc-dev/sqlc/issues?q=is%3Aissue+is%3Aopen+nullable+embed
😢
Emyrk
approved these changes
Jun 20, 2024
All except the organization IDs. We can add this as well if needed, but the complaint was specifically about last_seen_at.
cb386a0 to
1eb189a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All except the organization IDs; those continue to be omitted. We can add the organization IDs as well if needed, but the complaint was specifically about
last_seen_at. Not sure how valuable it is to have the organization IDs.Originally I tried
sqlc.embedbut if the left join ends up with a null then we get an error (not sure if this happens in practice as it looks like users are soft deleted; I manually deleted a user to test the behavior). Maybe there is a clever way to get it working though? At least the test should catch if we make future additions in one spot but not the other.