Skip to content

chore(site): refactor popover to make it easier to extend #13611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #13035

@BrunoQuaresma BrunoQuaresma requested a review from Parkreiner June 20, 2024 17:12
@BrunoQuaresma BrunoQuaresma self-assigned this Jun 20, 2024
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
I didn't see anything weird or wonky with the logic, so I'm hoping the failing tests were just because a few files didn't get updated yet

@BrunoQuaresma BrunoQuaresma merged commit cbdaa63 into main Jun 21, 2024
28 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/extend-popover branch June 21, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants