Skip to content

chore: group dependencies #13798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2024
Merged

chore: group dependencies #13798

merged 4 commits into from
Jul 8, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 6, 2024

This should help reduce dependabot noise. Probably grouping can be further improved.

@matifali matifali self-assigned this Jul 6, 2024
@matifali matifali requested a review from aslilac July 6, 2024 12:37
@matifali matifali changed the title chore: group frontend dependencies chore: group dependencies Jul 8, 2024
@matifali matifali requested a review from coadler July 8, 2024 12:08
@aslilac
Copy link
Member

aslilac commented Jul 8, 2024

I know we had this before, so I'm curious why it was removed. Was it causing any issues?

@matifali
Copy link
Member Author

matifali commented Jul 8, 2024

@aslilac we did had them in #8453 but were still not happy with amount of PRs dependabot was creating. So we created a single large group of everything in #10870. This made the PRs unmergeable and was creating PRs with 67 dependencies update in a single PR.
So again adding some very carefully chosen groups should provide an acceptable middle ground.

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for explaining, I like this approach 😄

@matifali
Copy link
Member Author

matifali commented Jul 8, 2024

@aslilac Please go over the packages.json and dependabot.yaml to see if it can be further optimized.
I am waiting for @coadler approval too.

Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The golang.org/x/* group seems good to me

@matifali matifali merged commit 05fdb9c into main Jul 8, 2024
26 checks passed
@matifali matifali deleted the matifali/npm-dependabot-groups branch July 8, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants